ReactionMechanismGenerator / ARC

ARC - Automatic Rate Calculator
https://reactionmechanismgenerator.github.io/ARC/index.html
MIT License
42 stars 21 forks source link

Gaussian Troubleshoot Combinations Improvement #670

Closed calvinp0 closed 7 months ago

calvinp0 commented 1 year ago

The current version of ARC cannot fully troubleshoot Gaussian due to lack of combination troubleshooting. This PR attempts to rectify this issue.

For example, if a job receives a first error of L401/301, and so we remove the chkfile by changing guess=read to guess=mix but then it its next failed run it gives another error where we need to add scf=(nosymm), then this modification will create an input.gjf file that uses BOTH troubleshooting methods.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (7f5190d) 73.54% compared to head (d8420a7) 73.67%.

:exclamation: Current head d8420a7 differs from pull request most recent head 66dc921. Consider uploading reports for the commit 66dc921 to get more accurate results

Files Patch % Lines
arc/job/trsh.py 72.22% 10 Missing and 10 partials :warning:
arc/job/adapters/gaussian.py 51.28% 17 Missing and 2 partials :warning:
arc/job/adapters/common.py 70.58% 7 Missing and 8 partials :warning:
arc/scheduler.py 0.00% 9 Missing :warning:
arc/job/adapters/gaussian_test.py 93.33% 0 Missing and 5 partials :warning:
arc/species/species.py 0.00% 2 Missing :warning:
arc/imports.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #670 +/- ## ========================================== + Coverage 73.54% 73.67% +0.13% ========================================== Files 99 99 Lines 26620 26866 +246 Branches 5545 5593 +48 ========================================== + Hits 19578 19794 +216 - Misses 5672 5679 +7 - Partials 1370 1393 +23 ``` | [Flag](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/670/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | `73.67% <76.94%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.