ReactionMechanismGenerator / ARC

ARC - Automatic Rate Calculator
https://reactionmechanismgenerator.github.io/ARC/index.html
MIT License
42 stars 21 forks source link

Special chars creating submit issues #723

Closed calvinp0 closed 6 months ago

calvinp0 commented 6 months ago

issue was stemming from local.py, the var called cmd cmd = f'cd {path}; {submit_cmd} {submit_filename}'

here we defined path but never put it in quotations so special chars like [ and ] would be misinterpreted by the shell

so in python would change to the direct of /rxn_120_CCN/ instead of /rxn120[CH2]CN/ (assuming out intention was to go to /rxn120[CH2]CN/)

so just needed to change it to

cmd = f'cd "{path}"; {submit_cmd} {submit_filename}'

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (431854b) 73.71% compared to head (9a88498) 73.71%.

Files Patch % Lines
arc/job/local.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #723 +/- ## ======================================= Coverage 73.71% 73.71% ======================================= Files 99 99 Lines 26992 26992 Branches 5620 5620 ======================================= + Hits 19896 19898 +2 + Misses 5698 5697 -1 + Partials 1398 1397 -1 ``` | [Flag](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/723/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/723/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | `73.71% <50.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.