codecov[bot]
commented
1 week ago Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
Project coverage is 73.67%. Comparing base (
3dbdbe0) to head (99f141e).
| Files | Patch % | Lines |
|---|---|---|
| arc/scheduler.py | 0.00% | 3 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #749 +/- ## ======================================= Coverage 73.66% 73.67% ======================================= Files 99 99 Lines 27406 27406 Branches 5765 5765 ======================================= + Hits 20188 20190 +2 + Misses 5771 5768 -3 - Partials 1447 1448 +1 ``` | [Flag](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/749/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/749/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | `73.67% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
An IRC job is supposed to give us the minimal energy path that connects a TS to its adjacent wells (reactants and products). ARC optimizes the two resulting IRC output to get the wells. However, it also unnecessarily spawns a freq job for the IRC species. This is a bit of an overkill, since we just want to see that the connectivity is correct, we don't use the IRC results per se in the calculations, so we don't care about their frequency (or whether there's an imaginary frequency). Plus, this computation is relatively expensive. sp and scan jobs are also not needed. Here we tell ARC not to spawn freq jobs for species defined from IRC jobs