ReactionMechanismGenerator / ARC

ARC - Automatic Rate Calculator
https://reactionmechanismgenerator.github.io/ARC/index.html
MIT License
43 stars 22 forks source link

Reduce clutter in restart dict #751

Closed alongd closed 5 months ago

alongd commented 5 months ago

Don't save default values of ARC, ARCSpecies, and ARCReaction objects as dictionaries Tests modified accordingly

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 54.45545% with 46 lines in your changes missing coverage. Please review.

Project coverage is 73.67%. Comparing base (34ef50d) to head (728aeea).

Files Patch % Lines
arc/main.py 25.71% 11 Missing and 15 partials :warning:
arc/species/species.py 67.27% 8 Missing and 10 partials :warning:
arc/reaction.py 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## ========================================== - Coverage 73.77% 73.67% -0.11% ========================================== Files 99 99 Lines 27364 27406 +42 Branches 5723 5765 +42 ========================================== + Hits 20189 20190 +1 - Misses 5748 5768 +20 - Partials 1427 1448 +21 ``` | [Flag](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/751/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | `73.67% <54.45%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.