ReactionMechanismGenerator / ARC

ARC - Automatic Rate Calculator
https://reactionmechanismgenerator.github.io/ARC/index.html
MIT License
42 stars 21 forks source link

Don't consider atoms in a ring as distinct groups for symmetry #752

Closed alongd closed 3 days ago

alongd commented 6 days ago

When generating conformers and looking for torsion symmetry, avoid considering atoms that are in the same ring.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.67%. Comparing base (c043eed) to head (1c4713d).

Files Patch % Lines
arc/species/conformers.py 83.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #752 +/- ## ========================================== + Coverage 73.66% 73.67% +0.01% ========================================== Files 99 99 Lines 27406 27418 +12 Branches 5765 5771 +6 ========================================== + Hits 20188 20200 +12 Misses 5769 5769 Partials 1449 1449 ``` | [Flag](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/752/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ReactionMechanismGenerator/ARC/pull/752/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator) | `73.67% <83.33%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ReactionMechanismGenerator#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.