ReactionMechanismGenerator / AutoTST

AutoTST: A framework to perform automated transition state theory calculations
Other
32 stars 16 forks source link

Added account specification to a Job #64

Closed nateharms closed 4 years ago

nateharms commented 4 years ago

This PR does the following:

codecov[bot] commented 4 years ago

Codecov Report

Merging #64 into master will increase coverage by 1.90%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   62.83%   64.73%   +1.90%     
==========================================
  Files          27       27              
  Lines        4601     4841     +240     
==========================================
+ Hits         2891     3134     +243     
+ Misses       1710     1707       -3     
Impacted Files Coverage Δ
autotst/reaction_test.py 99.58% <0.00%> (+0.08%) :arrow_up:
autotst/job/job.py 44.10% <0.00%> (+2.10%) :arrow_up:
autotst/reaction.py 84.66% <0.00%> (+4.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd1b67f...f19b5a3. Read the comment docs.

nateharms commented 4 years ago

I made a small fix-up to make submission faster but it now works on XSEDE. No word on if the memory leak is 100% fixed, but at least we are able to add an account to a job. @davidfarinajr can you review this in the next few days so we can get this merged in?

nateharms commented 4 years ago

Okay, @davidfarinajr we can discuss these potential changes on Monday, but just checking in on XSEDE and it's running fine for a reaction!

davidfarinajr commented 4 years ago

@nateharms, can you do a quick fix up commit for the ‘number_of_atoms‘? Then we’ll merge it in

nateharms commented 4 years ago

Done, and the checks pass. I'll merge it in then