rwest commented 4 years ago

These are nicer to look at, easier to debug, etc.

I did these using the "convert to f-string literal" code intention in PyCharm. Click inside a .format() string somewhere and press Alt-Enter on your keyboard, then select "convert to f-string literal".

This first commit I just did a couple of files.

There are probably some tools to do it faster than one at a time, like https://github.com/asottile/pyupgrade

Think about when best to do this in regards other open pull requests, to minimize merge conflicts. But I think it's worth doing - either with one concerted effort or gradually as you touch code.

codecov[bot] commented 4 years ago

Codecov Report

Merging #67 into master will increase coverage by <.01%. The diff coverage is 45.81%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   63.77%   63.78%   +<.01%     
==========================================
  Files          27       27              
  Lines        4663     4667       +4     
==========================================
+ Hits         2974     2977       +3     
- Misses       1689     1690       +1

Impacted Files	Coverage Δ
autotst/calculator/vibrational_analysis_test.py	`83.07% <ø> (ø)`	:arrow_up:
autotst/calculator/vibrational_analysis.py	`86.3% <0%> (ø)`	:arrow_up:
autotst/data/update.py	`10.31% <0%> (ø)`	:arrow_up:
autotst/geometry.py	`88.63% <0%> (ø)`	:arrow_up:
autotst/species.py	`71.25% <100%> (ø)`	:arrow_up:
autotst/job/job_test.py	`98.96% <100%> (ø)`	:arrow_up:
autotst/data/base.py	`38.4% <22%> (ø)`	:arrow_up:
autotst/conformer/systematic.py	`61.2% <33.33%> (ø)`	:arrow_up:
autotst/job/job.py	`44.1% <48.78%> (ø)`	:arrow_up:
autotst/data/inputoutput.py	`65.25% <50%> (ø)`	:arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb67c2d...16ca1ec. Read the comment docs.