ReactionMechanismGenerator / RMG-Java

The Java version of RMG: Reaction Mechanism Generator
http://rmg.sourceforge.net/
MIT License
29 stars 36 forks source link

Irreversible reactions may not be handled properly in Primary Reaction Library (OLD) #62

Open shamelmerchant opened 14 years ago

shamelmerchant commented 14 years ago

Reaction is taken as reversible even when we specify it as an irreversible in Primary Reaction Library (old). I think as we only grab the kinetics from PRL it dosent check if other direction exist and generates reversible reaction also.

In Reaction Library C4H10 => C2H5 + C2H5 3.870E+70 2.700 0.00 0.0 0.0 0.0

Reported in Chemkin File as reversible C4H10(1)=C2H5(13)+C2H5(13) 3.870e+70 2.70 0.00 !R_Recombination: Primary Reaction Library: RLtry

The same issue also exist with Pdep Reaction they are taken as reversible even when they were specified as irreversible in the Reaction Library

mrharper commented 14 years ago

I've pushed something that resolves some of these issues: http://github.com/mrharper/RMG-Java/commit/a29053367423b0fac4dfd5314e231328deaf0663

This issue is not resolved (which is why it's not on my master branch). I think this is a relatively minor issue (in the documentation, we can inform the user not to use irreversible reactions) and I'm not clever enough to resolve this issue in the relatively short time we have left before the commit.

I'm removing the 3.2 tag, but adding a Feature tag

mrharper commented 13 years ago

This issue has been added to the "Known Issues" portion of the RMG documentation: https://github.com/GreenGroup/RMG-Java/commit/9ca91294e0a7cf7422eb14720757687230e42150

MRH is adding the "3.4 or later" tag to this issue.