Closed cgrambow closed 5 years ago
I think that the butadiene <-> weirdo transition should be a reaction rather than resonance, since it involves relocating a hydrogen atom.
I agree that with the implementation of the new resonance structures we're starting to see weird carbenes, which we aren't well equipped to handle.
A specific solution might be allowing charged atoms in the RR'
node of 1,2_Insertion_carbene
. Something like might work:
1 *2 [Cs,Sis,N] u0 cx {2,S} {3,S} {4,S} {5,S}
2 *3 [Cs,Cd,Cb,Ct,Sis,Sid,N,S] u0 cx {1,S}
3 H u0 {1,S}
4 H u0 {1,S}
5 H u0 {1,S}
However, we should probably also rethink the atoms we allow to gain a lone pair in resonance transitions.
We should resolve this before the next release (mid-December). I think we only have two options:
I'm currently leaning more towards the first option.
I think we (or at least I) don't have good chemical intuition for carbene reactions and resonance, I'm OK with the first option. I'll make this change soon.
Bug Description
In a version of the
minimal
model, RMG adds this species (which will henceforth be referred to as weirdo) to the edge:which gets created from butadiene (
C=CC=C
) using theSinglet_Carbene_Intra_Disproportionation
family. So somehow, RMG decided butadiene reacting to weirdo should be a reaction instead of a resonance structure. It then decides that the reaction is significant enough and adds weirdo to the core. RMG then tries to generate kinetics for a reaction involving weirdo in the1,2_Insertion_carbene
family, which promptly results in anUndeterminableKineticsError
. The error message is:So somehow the reaction got created even though it then doesn't match the template of the family. Note that the SMILES in the error message are wrong, because apparently RDKit doesn't correctly parse weirdo.
How To Reproduce
Try generating kinetics for weirdo on the RMG website. See here.
Possible Solutions
Maybe we could forbid such transformations in
Singlet_Carbene_Intra_Disproportionation
? Or we could try to fix the template issue in1,2_Insertion_carbene
. Another issue is that RMG evidently thinks that the reactionbutadiene -> weirdo
is fast enough to add it to the core, which makes no sense to me since its estimated heat of reaction for the reverse, i.e.,weirdo -> butadiene
is 65.93 kcal/mol and the kinetics for the reverse are