Closed sevyharris closed 8 months ago
⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.86%. Comparing base (
eed950a
) to head (13f99f6
).:exclamation: Current head 13f99f6 differs from pull request most recent head 8cac4c7. Consider uploading reports for the commit 8cac4c7 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
TIL what
f.tell
is! Thanks for making this PR. couple small things. Overall looks like a nice patch.
Thank you @JacksonBurns for reviewing! Let me know if you have any additional comments or suggestions.
⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
Make chemkin read of transport and thermo files more robust
Motivation or Problem
I ran into these two issues while importing the Aramco 3.0 mechanism:
UnsupportedOperation: can't do nonzero cur-relative seeks
Description of Changes
Read in the shape_index as a float and then convert it to an int. This works whether the data is formatted as 0 or 0.000
Testing
Part 1 - separate thermo file
mech_file = 'mech.txt' thermo = 'thermo.txt' transport = 'tran.txt' dictionary_path = 'species_dictionary.txt'
species_list, reaction_list = rmgpy.chemkin.load_chemkin_file(mech_file, dictionary_path=dictionary_path, transport_path=transport, thermo_path=thermo)
import rmgpy.chemkin mech_file = 'full_mech.txt' transport = 'tran_float.txt' dictionary_path = 'species_dictionary.txt' species_list, reaction_list = rmgpy.chemkin.load_chemkin_file(mech_file, dictionary_path=dictionary_path, transport_path=transport)