Open donerancl opened 6 months ago
@JacksonBurns Is this failed "Continuous Integration / build-and-test-linux " check the same issue as in PR #2663?
Yes, I am working on diagnosing it here: https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2667
@hwpang and @JacksonBurns reviewing
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days.
@donerancl is this PR tied to the fragment paper? Do we revive this, and maybe ping bill?
@JacksonBurns I made this one for the polyethylene pyrolysis project, which comes after the work in the AFM paper. We should revive it, but no need to ping Bill. I have not gotten a chance to finish his edits on the AFM manuscript yet. I can see about resolving any merge conflicts.
Motivation or Problem
Sometimes, when RMG cuts a large molecule during mechanism generation, it is possible to make a fragment already present in the mechanism, but RMG makes a new fragment, making the mechanism larger than it needs to be.
Description of Changes
So far, I've made the following changes:
rmgpy/rmg/model.py
rmgpy/molecule/fragment.py
I would like to add a feature where RMG checks if the any of the potential cutting schemes produce fragments already present in the core mechanism and prefers creating those.
Testing
I am using the branch to generate a mechanism