github actions CI maintainence

ReactionMechanismGenerator / RMG-Py

Python version of the amazing Reaction Mechanism Generator (RMG).

Other

387 stars 227 forks source link

Closed JacksonBurns closed 3 months ago

JacksonBurns commented 3 months ago

increment miniconda setup to v3 from v2
set macos build runner to use intel macs rather than m1, since we don't have binaries for m1
switch download artifact step to use the official github one, which now allows grabbing artifacts from other runs

JacksonBurns commented 3 months ago

This should fail at the 'download stable regression results' step, complaining that it could not find the artifact, possibly specifying that the reason it couldn't find it is because it was upload with a previous version of the upload artifact action (see: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md#which-versions-of-the-artifacts-packages-are-compatible). That would be resolved by ignoring this failure and merging anyway, then letting the CI run on main.

JacksonBurns commented 3 months ago

Do we need to do anything to RMG-database also?

yes! thanks for the reminder. will do this now

JacksonBurns commented 3 months ago

@rwest could you take a look at https://github.com/ReactionMechanismGenerator/RMG-database/pull/652? It's the database half of this PR. Both should 'fail' in the same way.