Open jonwzheng opened 3 months ago
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
Wow, we have a lot of wiki pages. A lot of them will need to be either consolidated into the RMG-Py main docs (#2704) or the new CONTRIBUTING.md
(#2705). I suggest we merge #2704 in for a first-pass update of the website. Then we can open a follow-up PR that folds in the info from the Wiki pages. Just to avoid overwhelming code review with a huge PR that includes tons of changes to the docs.
My thoughts on some of the pages with ?
:
Thanks, Jackson! I thought about it some more and it seems that we may just want to make the wiki invisible rather than permanently delete all the files. Maybe we can consolidate everything from here to the contribute/main docs and then just toggle the visibility.
Good point! We should also put a note at the top when we make it invisible saying why we have done so.
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
All of the wiki docs have been ported to the RMG-Py PR #2705 except for:
CONTRIBUTING.md
w/ this and the RMG release package?WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.78%. Comparing base (
43d5bf8
) to head (b7712cb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. WARNING:root:Initial mole fractions do not sum to one; normalizing. ⚠️ One or more regression tests failed. Please download the failed results and run the tests locally or check the log to see why.
beep boop this comment was written by a bot :robot:
Motivation or Problem
This PR will serve as a hub to fix the various issues with currently outdated wiki/docs outlined in #2686.
The current plan is to engage in these steps:
CONTRIBUTING.md
which can be linked to anyone attempting to open a PR (#2705), and also the main RMG-Py documentation (#2707)Progress on updating the Wiki: