Closed yunsiechung closed 2 years ago
jonwzheng
commented
2 years ago Hi Yunsie, thanks for the work in making this PR. This is a great change.
Sorry the review is taking longer than expected. The code looks good. There are some unexpected problems with the dev server that I am trying to fix before I can test this out. Thanks for being patient.
jonwzheng
commented
2 years ago Hi Yunsie, I was able to test this out. The website changes function as expected.
I was able to run the change on the dev server and on my local machine without the migration changes. As per PR #231 I believe we only need to make migrations when models.py is changed. Perhaps there is an inconsistency in your migration history. Or, let me know what error you were getting before that you needed to run make migrations. I would suggest rolling back the migrations commit before we merge this in.
yunsiechung
commented
2 years ago @jonwzheng Thank you! I removed my previous commit related to the migration files and force-pushed it! I don't know why I had different migration files. Does this still work?
Motivation
Currently, the Solute and Solvation LSER Search using the group contribution method only displays the name of the groups found for the input molecules as shown below.
This is inconvenient since the user has to search for each group if they want to know the group value.
Changes Made
This commit now adds the hyperlink to each group found for the group contribution method as shown below. Clicking each group will direct the user to the page containing the detailed information of the group.
Similar changes have been made for the solute parameter search using the RMG-database. Clicking the comment will direct the user to the page containing the matched library entry.