ReactionMechanismGenerator / RMG-website

A Django-powered website for Reaction Mechanism Generator (RMG)
Other
21 stars 29 forks source link

Remove RMG-Java code and fix various related glitches #281

Closed jonwzheng closed 3 months ago

jonwzheng commented 3 months ago

Motivation

We decided several months ago that RMG-Py will no longer support any RMG-Java functionality (see https://github.com/ReactionMechanismGenerator/RMG-Py/commit/9f293bec90a093cf23b42089bb7bb0b14e05a2a7).

This means that RMG-website also will not be able to support those functions, unless some of the functions are ported over. Indeed, the save_html_file that was removed from RMG-Py was used in some of the RMG-website tools.

This PR

To reduce the possibility of further error, and to be consistent with RMG-Py's philosophy, this PR removes any code related to RMG-Java. It also fixes a couple of related errors:

Side note

This is not the first time that removal of deprecated RMG-Py code affected RMG-website downstream. We may want to consider including the RMG website build into the RMG-Py CI workflow, but I think this would be too slow/perhaps unnecessary.

Another option is to set up CI for RMG-website; that way we can catch these errors at least during PRs and during regular build tests. (See #280)