ReactionMechanismGenerator / ReactionMechanismSimulator.jl

The amazing Reaction Mechanism Simulator for simulating large chemical kinetic mechanisms
https://reactionmechanismgenerator.github.io/ReactionMechanismSimulator.jl
MIT License
75 stars 32 forks source link

Interfaces for two phase pyrolysis and bug fix #194

Closed hwpang closed 2 years ago

hwpang commented 2 years ago

Added interfaces for two-phase pyrolysis and fixed some bugs for four party reactions and multi-domain reactor.

codecov[bot] commented 2 years ago

Codecov Report

Merging #194 (956c03d) into main (cf156ab) will increase coverage by 0.23%. The diff coverage is 64.70%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   47.58%   47.81%   +0.23%     
==========================================
  Files          29       29              
  Lines        6515     6596      +81     
==========================================
+ Hits         3100     3154      +54     
- Misses       3415     3442      +27     
Impacted Files Coverage Δ
src/Calculators/kLAkH.jl 85.71% <0.00%> (ø)
src/Simulation.jl 30.51% <0.00%> (-0.15%) :arrow_down:
src/Domain.jl 57.95% <37.50%> (-0.27%) :arrow_down:
src/Reactor.jl 47.41% <58.53%> (+0.27%) :arrow_up:
src/Interface.jl 88.76% <100.00%> (+2.18%) :arrow_up:
src/TestReactors.jl 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

hwpang commented 2 years ago

@mjohnson541 I think I addressed all the comments and all tests have passed.