search

ReactionMechanismGenerator / ReactionMechanismSimulator.jl

The amazing Reaction Mechanism Simulator for simulating large chemical kinetic mechanisms
https://reactionmechanismgenerator.github.io/ReactionMechanismSimulator.jl
MIT License
74 stars 33 forks source link

Add function to save the solution #214

Closed hwpang closed 10 months ago

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eed1896) 49.82% compared to head (7074e9c) 49.91%. Report is 21 commits behind head on main.

:exclamation: Current head 7074e9c differs from pull request most recent head a165085. Consider uploading reports for the commit a165085 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================== + Coverage 49.82% 49.91% +0.08% ========================================== Files 31 31 Lines 8086 7920 -166 ========================================== - Hits 4029 3953 -76 + Misses 4057 3967 -90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hwpang commented 11 months ago

I rebased with main. @mjohnson541 can you review & merge after the tests pass?

hwpang commented 10 months ago

Looks mostly good to me. Should we add a read function to go with the save function?

I don't think it makes sense to add it into this PR, but I agree it would be nice to have a load function. We can open up an issue for that.

hwpang commented 10 months ago

@mjohnson541 I addressed the comments!