ReactionMechanismGenerator / ReactionMechanismSimulator.jl

The amazing Reaction Mechanism Simulator for simulating large chemical kinetic mechanisms
https://reactionmechanismgenerator.github.io/ReactionMechanismSimulator.jl
MIT License
74 stars 33 forks source link

Add functions to convert dict to appropriate typing for threaded SA #215

Closed hwpang closed 1 year ago

hwpang commented 1 year ago

The Julian way to do this done in https://github.com/ReactionMechanismGenerator/ReactionMechanismSimulator.jl/pull/212 does not work, because we can't do multiple dispatch with keyword arguments.

codecov[bot] commented 1 year ago

Codecov Report

Merging #215 (3538dbd) into main (deb4bac) will increase coverage by 0.00%. The diff coverage is 72.72%.

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   49.81%   49.81%           
=======================================
  Files          31       31           
  Lines        7904     7908    +4     
=======================================
+ Hits         3937     3939    +2     
- Misses       3967     3969    +2     
Impacted Files Coverage Δ
src/ThreadedSensitivities.jl 70.00% <72.72%> (-1.22%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more