search

ReactionMechanismGenerator / ReactionMechanismSimulator.jl

The amazing Reaction Mechanism Simulator for simulating large chemical kinetic mechanisms
https://reactionmechanismgenerator.github.io/ReactionMechanismSimulator.jl
MIT License
70 stars 33 forks source link

Fix documentation #221

Closed mjohnson541 closed 9 months ago

mjohnson541 commented 1 year ago

As per issue https://github.com/ReactionMechanismGenerator/ReactionMechanismSimulator.jl/issues/220. We need to change the documentation calls from domain,y0 = ConstantTVDomain(phase=liq,initialconds=initialconds,constantspecies=["oxygen"]) to domain,y0,p = ConstantTVDomain(phase=liq,initialconds=initialconds,constantspecies=["oxygen"])

mjohnson541 commented 1 year ago

It looks like we already made these modifications. Something must be wrong with docs deployment.

mjohnson541 commented 1 year ago

Seems like at some point we stopped updating gh-pages and the online documentation stopped changing.

mjohnson541 commented 1 year ago

I'm wondering a bit if Documenter.jl is hard coded somewhere to use master and that we broke this system when we switched to main...I've updated master to current main to see if that helps, but I am unable to test currently with the environment issues after the changes in RMG.

mjohnson541 commented 9 months ago

Resolved with #236