search

ReactionMechanismGenerator / ReactionMechanismSimulator.jl

The amazing Reaction Mechanism Simulator for simulating large chemical kinetic mechanisms
https://reactionmechanismgenerator.github.io/ReactionMechanismSimulator.jl
MIT License
74 stars 33 forks source link

Fix symbolic bug #252

Closed mjohnson541 closed 5 months ago

mjohnson541 commented 6 months ago

Fix bug when feeding symbolic variables through getkfkrev.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 52.74725% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 48.56%. Comparing base (1f37bfd) to head (38cc087).

Files Patch % Lines
src/PhaseState.jl 64.70% 48 Missing :warning:
src/ReactionMechanismSimulator.jl 0.00% 28 Missing :warning:
src/Reactor.jl 44.44% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #252 +/- ## ========================================== - Coverage 48.71% 48.56% -0.15% ========================================== Files 31 31 Lines 8313 8351 +38 ========================================== + Hits 4050 4056 +6 - Misses 4263 4295 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mjohnson541 commented 6 months ago

I've also added finite differences as a Jacobian source and improved our handling of jac_prototype.

mjohnson541 commented 6 months ago

Decided to not add finite differences because how much the accuracy of the Jacobian degrades.