search

Reactive-Extensions / RxJS

The Reactive Extensions for JavaScript
http://reactivex.io
Other
19.48k stars 2.1k forks source link

GroupBy API documentation is out of date #1197

Open larsnystrom opened 8 years ago

larsnystrom commented 8 years ago

The documentation lists three arguments for Rx.Observable.prototype.groupBy(keySelector, [elementSelector], [comparer]), but there are only two arguments in the code: https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/linq/observable/groupby.js

The third argument was removed in 73cbf847512b794a69dddb02bbb4f59ce279c384.

larsnystrom commented 8 years ago

Same goes for groupByUntil https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/groupbyuntil.md

lucidNTR commented 8 years ago

+1 this cost me some time :-( also i need a comparer