Reactive-Extensions / RxJS

The Reactive Extensions for JavaScript
http://reactivex.io
Other
19.48k stars 2.1k forks source link

rxjs-compat subscribe have no effect #1556

Open Frennetix opened 6 years ago

Frennetix commented 6 years ago

I use a library ng2-bs3-modal and after upgrading my project to version 6.x.x the subscribe have no effect:

<bs-modal #modal>
  ...
</bs-modal>

@ViewChild('modal')
modal1: BsModalComponent;

this.modal1.onClose.subscribe(
  () => {
    console.log('close');
  }
)

Repo to reproduce: https://github.com/Frennetix/rxjs6-ng2-bs3-modal

Frennetix commented 6 years ago

I'll add that: this.modal1.onOpen.emit();

trigger the subscribe()

whiteinge commented 6 years ago

This repo is for the Rx 4 version. You want https://github.com/ReactiveX/rxjs instead.