Reactive-Extensions / rx.angular.js

AngularJS Bindings for RxJS
Other
827 stars 89 forks source link

Some remarks on the doc #107

Closed PhiLhoSoft closed 8 years ago

PhiLhoSoft commented 8 years ago

Referring to https://github.com/Reactive-Extensions/rx.angular.js/tree/master/docs

General remark: not sure if there is a difference between observeOnScope and $toObservable. BTW, why the former must be injected separately?

sirbarrence commented 8 years ago

There's a pencil button in the top right corner of .md files in the repo that makes it really easy to make quick corrections and submit a pull request for simple typos like these, all from the browser. I've had many doc corrections accepted this way.

PhiLhoSoft commented 8 years ago

@sirbarrence False feeling of simplicity... :smile: This isn't a wiki, clicking on this pencil will fork the project and we must do all the complex and lengthly dance of GitHub PRs to propose a change. Beside, if there are typos indeed easy to fix, I expected some feedback on some of my remarks. That said, I am willing to do the above dance to fix some things. I suppose I can go ahead, do some fixes, hoping they are OK.

BTW, I don't know if one can easily cherry-pick some changes while rejecting others (line per line) in a GH PR.

mattpodwysocki commented 8 years ago

Closing as per work by @sirbarrence