search

Reactive-Extensions / rx.angular.js

AngularJS Bindings for RxJS
Other
827 stars 89 forks source link

Plan to use Rx5 instead of Rx4 due to breaking changes? #122

Open tihuan opened 8 years ago

tihuan commented 8 years ago

Since Rx5 introduces some breaking changes (link), I was wondering if rx.angular.js will eventually move to Rx5 too.

For example, rx.Observable.replay() is now rx.Observable.publishReplay() in Rx5.

P.S. I'm using rx.angular.js in an ng1.4.8 app :)

Thanks a lot!

nmn commented 8 years ago

I know this is frowned upon, but +1.

tihuan commented 8 years ago

Hey @nmn! I'm still very new to RxJS, so could you elaborate on why this is frowned upon :)? Thanks a lot!

nmn commented 8 years ago

@tihuan I was talking about the "+1" comments on github.

tihuan commented 8 years ago

@nmn Ahaha, I see! I didn't know that's a thing! TIL :santa:

samal-rasmussen commented 8 years ago

There are actually a bunch of api changes between rx 4 and 5 now: https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md

awk commented 8 years ago

I just created https://github.com/Reactive-Extensions/rx.angular.js/pull/146 which contains the changes to make rx.angular.js work with RxJS 5 (beta 8 - but I expect the changes will continue to work future betas as RxJS 5 closes on RC the incompatible changes should be fewer)

tihuan commented 8 years ago

Woohoo! Thanks for the fabulous work 💯 !

samal-rasmussen commented 8 years ago

You the man @awk!

mickdelaney commented 7 years ago

Is this still on the cards ?

mattbrunetti commented 7 years ago

@mickdelaney I hope so!

trojanc commented 7 years ago

I need this too please!

mattbrunetti commented 7 years ago

Rx5 with Angular 1 ?

note: There's some discussion on this issue in the PR #146

trojanc commented 7 years ago

I saw that one, should have paid more attention to it, thanks.