Reactive-Extensions / rx.angular.js

AngularJS Bindings for RxJS
Other
827 stars 89 forks source link

Error occurred with rx.angular.min.js 0.0.11 and rx.all.js 2.3.13 #42

Closed andretw closed 10 years ago

andretw commented 10 years ago

I've got an error and test the combinations. Both of the files are in its /dist directory. (AngularJS v1.2.13)

(O) rx.angular.js 0.0.11 - rx.all.js 2.3.13 (O) rx.angular.js 0.0.11 - rx.all.min.js 2.3.13 (X) rx.angular.min.js 0.0.11 - rx.all.js 2.3.13 (X) rx.angular.min.js 0.0.11 - rx.all.min.js 2.3.13

screen shot 2014-10-16 at 6 14 55 pm

screen shot 2014-10-16 at 7 09 43 pm

rossbayer commented 10 years ago

Out of curiosity, are you concatenating RxJS and rx-angular into a single script file? I noticed the same problem recently, and at least the temporary fix (till I can look at it more closely) was to concatenate the rxjs.all.min.js file with the non-minified rx.angular.js file into my application's script.

Also, I don't seem to be able to reproduce the problem via a very simple Plunker with separate <script> elements for rxjs and rx-angular, something like:

  <head>
    <link rel="stylesheet" href="style.css">
    <script type="text/javascript" src="http://cdnjs.cloudflare.com/ajax/libs/angular.js/1.2.20/angular.min.js"></script>
    <script type="text/javascript" src="http://cdnjs.cloudflare.com/ajax/libs/rxjs/2.3.14/rx.min.js"></script>
    <script type="text/javascript" src="http://localhost:9000/provisioning/webjars/rx-angular/0.0.11/rx.angular.min.js"></script>
    <script src="script.js"></script>
  </head>
mattpodwysocki commented 10 years ago

@andretw fixed as of v0.0.12