search

ReactiveBayes / ExponentialFamilyProjection.jl

A library to project an arbitrary function to an exponential family member distribution with the manifold optimization
MIT License
9 stars 0 forks source link

Direction rule as argument to projection parameters #31

Closed ismailsenoz closed 3 months ago

ismailsenoz commented 3 months ago

This small PR makes direction update rule argument to ProjectionParameters structures, so that we can manipulate the scale of BoundedNormUpdateRule or test with other rules from manopt.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.82%. Comparing base (5856bae) to head (83f6b96).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## ======================================= Coverage 97.81% 97.82% ======================================= Files 7 7 Lines 275 276 +1 ======================================= + Hits 269 270 +1 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nimrais commented 3 months ago

I made several changes to the PR.

The first test showcases the BoundedNormUpdateRule for Maximum Likelihood Estimation across multiple distributions. This test is particularly noteworthy as it demonstrates that increasing the bound norm can lead to improved results, providing empirical evidence for the effectiveness of this approach.

The other two tests on integration of the Manopt.jl update rules, specifically that it's possible to use Momentum with this option.

albertpod commented 3 months ago

Generally, I think it's a good PR, guys. @Nimrais, thanks for the additional tests, they make the intention of the change clear.

For the future, let's strive to have tests that explicitly test the added feature. The first test from 1b0df2b wasn't particularly clear to me.