search

ReactiveBayes / ExponentialFamilyProjection.jl

A library to project an arbitrary function to an exponential family member distribution with the manifold optimization
MIT License
9 stars 0 forks source link

add extras #33

Closed wouterwln closed 2 weeks ago

wouterwln commented 3 weeks ago

This allows you to pass debug callbacks to ProjectedTo

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.24%. Comparing base (d2c93ae) to head (32cb64a). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== + Coverage 99.22% 99.24% +0.01% ========================================== Files 7 7 Lines 258 264 +6 ========================================== + Hits 256 262 +6 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bvdmitri commented 3 weeks ago

I like it and I think generally this is the way to go, but I would also:

Looking at the implementation IMO it also should break the debug key (didn't check the tests though) since before this update the kwargs variable was updated all the time, but in this PR this is updated only when extra is not nothing, which means that by default kwargs variable is not being updated anymore.