search

ReactiveBayes / GraphPPL.jl

DSL for probabilistic models specification and probabilistic programming.
MIT License
32 stars 5 forks source link

reimplement iterate for resizablearray #212

Closed wouterwln closed 5 months ago

wouterwln commented 5 months ago

This PR is a pain in the *ss since you have to keep track of the state and handle accordingly. I'm open to suggestions on how to improve

bvdmitri commented 5 months ago

@wouterwln please double check, imo good to go

wouterwln commented 5 months ago

Good to go, cannot submit review since I'm PR author

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.83%. Comparing base (51611f6) to head (b08723f). Report is 9 commits behind head on main.

Files Patch % Lines
src/resizable_array.jl 93.75% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #212 +/- ## ========================================== - Coverage 91.83% 91.83% -0.01% ========================================== Files 15 15 Lines 1935 1947 +12 ========================================== + Hits 1777 1788 +11 - Misses 158 159 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.