search

ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
254 stars 24 forks source link

Update mixture example #100

Closed bartvanerp closed 1 year ago

bartvanerp commented 1 year ago

Updates the Universal Mixtures example notebook as a start to #98

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

albertpod commented on 2023-04-14T13:18:08Z ----------------------------------------------------------------

Do you want to say here how Bethe free energy (one line) relates to log evidence?


albertpod commented 1 year ago

It's great. Please have a look at the comment I've made.

bartvanerp commented 1 year ago

@bvdmitri this PR only fails on nightly because Flux.jl/Zygote.jl cannot compile. This seems to be a more often occurring issue: https://github.com/FluxML/Flux.jl/issues/2097 :). If you are okay with these failing tests, then this PR is ready to merge.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.