Closed wouterwln closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Patch and project coverage have no change.
Comparison is base (
20a1499
) 79.91% compared to head (504e853
) 79.91%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This is a great addition, I like the story and the explanation is clear in my opinion. I would, however, argue that this should be added to the documentation instead as a page (not as an example) and ReactiveMP should have a documentation page with the API documentation. Would it be too difficult to convert the example to a documentation page? The documentation does allow code execution too. See the @example
macro from the Documenter
.
I've addressed my own comments. The rest is fine by me. Thanks @wouterwln and @bartvanerp !
Here's my initial effort to create a tutorial for making a custom node. There's a couple of things I had questions about and that I left intentionally vague, so this is by no means my final effort towards this. My questions are the following:
RxInfer
was really eager on using theq_out
variational update rule towardsp
. However, in my head, there's no reason to use the variational update rule over the sum-product rule in this modelI'll expand the latter part of the explanation (from the marginal computation onwards) a bit further later, but as of writing this it's 6pm on a Friday so my brain is fried. Have a nice weekend.