ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
254 stars 24 forks source link

feat: add diagnostic check after inf entropies subtraction #110

Closed bvdmitri closed 1 year ago

bvdmitri commented 1 year ago

@HoangMHNguyen

It doesn't fully solve the problem with connecting observations to a deterministic node, but at least it gives a hint what could have gone wrong. The actual fix for the FE computation will take some time.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 :tada:

Comparison is base (a746558) 80.18% compared to head (f564473) 80.29%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================== + Coverage 80.18% 80.29% +0.11% ========================================== Files 11 11 Lines 1201 1208 +7 ========================================== + Hits 963 970 +7 Misses 238 238 ``` | [Impacted Files](https://app.codecov.io/gh/biaslab/RxInfer.jl/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab) | Coverage Δ | | |---|---|---| | [src/score/bfe.jl](https://app.codecov.io/gh/biaslab/RxInfer.jl/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab#diff-c3JjL3Njb3JlL2JmZS5qbA==) | `94.00% <100.00%> (+0.97%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bvdmitri commented 1 year ago

@HoangMHNguyen @albertpod ping

HoangMHNguyen commented 1 year ago

Thanks @bvdmitri !