Update mountain car example

ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing

MIT License

254 stars 24 forks source link

Closed HoangMHNguyen closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

HoangMHNguyen commented 1 year ago

Thanks a lot for the feedback @bartvanerp @bvdmitri ! @Sepideh-Adamiat and I will address those issues

Sepideh-Adamiat commented 1 year ago

@bvdmitri @bartvanerp Thanks for your comments. We changed the notebook accordingly and made a new PR.

HoangMHNguyen commented 1 year ago

Thanks a lot @bartvanerp !

It's correct to change the starting index of the product to t.
Equation (1) is copied from Thijs's paper and I think it's clear. So there's no need to change it.

bvdmitri commented 1 year ago

Thanks guys! I'll take a look on why CI fails.