Closed bvdmitri closed 1 year ago
Patch coverage: 100.00%
and project coverage change: +0.09%
:tada:
Comparison is base (
6ad864e
) 81.22% compared to head (287aa85
) 81.32%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before:
BenchmarkTools.Trial: 6 samples with 1 evaluation.
Range (min … max): 929.941 ms … 1.077 s ┊ GC (min … max): 9.92% … 11.26%
Time (median): 957.682 ms ┊ GC (median): 11.08%
Time (mean ± σ): 987.136 ms ± 64.681 ms ┊ GC (mean ± σ): 11.12% ± 0.82%
█ █ █ █ █ █
█▁▁█▁▁▁▁▁▁█▁█▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁█▁▁▁▁▁█ ▁
930 ms Histogram: frequency by time 1.08 s <
Memory estimate: 528.79 MiB, allocs estimate: 4246814.
After
BenchmarkTools.Trial: 7 samples with 1 evaluation.
Range (min … max): 668.098 ms … 845.756 ms ┊ GC (min … max): 9.63% … 12.63%
Time (median): 725.226 ms ┊ GC (median): 11.92%
Time (mean ± σ): 739.858 ms ± 55.859 ms ┊ GC (mean ± σ): 11.65% ± 1.28%
█ █ ██ █ █ █
█▁▁▁▁▁▁▁▁▁▁▁▁▁█▁▁▁██▁▁█▁▁▁▁▁▁▁▁▁▁▁▁█▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁█ ▁
668 ms Histogram: frequency by time 846 ms <
Memory estimate: 485.53 MiB, allocs estimate: 3522721.
Previously the PointMass form constraint called slow optimization routine for
<: Distribution
objects, even though it is easier and faster to return themode
of the distribution. This PR fixes that. Found by @bartvanerp