ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
242 stars 24 forks source link

Add comparison to other packages #162

Closed albertpod closed 8 months ago

albertpod commented 9 months ago

This PR addresses #71

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (215f458) 81.03% compared to head (2e049a3) 81.03%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #162 +/- ## ======================================= Coverage 81.03% 81.03% ======================================= Files 11 11 Lines 1271 1271 ======================================= Hits 1030 1030 Misses 241 241 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

albertpod commented 8 months ago

@HoangMHNguyen made a few changes. Something occurred to me. Instead of binary table, perhaps we can make a ternary table.

For example, RxInfer is not universal compared to Turing, but it's more universal compared to ForneyLab or PGMax.

WDYT?

HoangMHNguyen commented 8 months ago

@albertpod I think that's a good idea, but we can just write an extra note below the table instead of creating a new table.

albertpod commented 8 months ago

@albertpod I think that's a good idea, but we can just write an extra note below the table instead of creating a new table.

@HoangMHNguyen perhaps we can use ~ symbol to denote partial capability? Something like: : Full capability or feature is present. ~ : Partial capability or feature is present. : No capability or feature.

HoangMHNguyen commented 8 months ago

Yes, that's even a better idea

bvdmitri commented 8 months ago

That is the status of this PR? Can it be reviewed and merged potentially? (Sorry if I missed smth, just trying to catch up after my sickness)

bvdmitri commented 8 months ago

@HoangMHNguyen @albertpod is this ready?

albertpod commented 8 months ago

@bvdmitri yes

bvdmitri commented 8 months ago

Great, I skimmed through it, looks good to me! Thanks guys!!