search

ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
265 stars 23 forks source link

Update Hierarchical BLR #206

Closed albertpod closed 9 months ago

albertpod commented 9 months ago

This PR fixes minor mistakes with Hierarchical Bayesian Linear Regression that we found following the discussion #199

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 9 months ago

View / edit / reply to this conversation on ReviewNB

bartvanerp commented on 2024-01-04T10:01:59Z ----------------------------------------------------------------

There are some versioning issues here


codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (afa07ef) 80.31% compared to head (0dbccb5) 80.31%. Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ======================================= Coverage 80.31% 80.31% ======================================= Files 11 11 Lines 1290 1290 ======================================= Hits 1036 1036 Misses 254 254 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

albertpod commented 9 months ago

@bartvanerp, perhaps that's because the new version of RxInfer.jl hasn't been released; examples look into the released version.

albertpod commented 9 months ago

@bartvanerp I see that tests for examples pass in CI.

bartvanerp commented 9 months ago

Hmm that's strange, in the notebook viewer it says that some cells failed. I don't think this reruns the code.

albertpod commented 9 months ago

Not sure why it happens then. It went well here https://github.com/biaslab/RxInfer.jl/pull/190

bartvanerp commented 9 months ago

The pushed notebook seems to contain the same errors: https://github.com/biaslab/RxInfer.jl/blob/fix-hlr-example/examples/basic_examples/Bayesian%20Linear%20Regression%20Tutorial.ipynb Did you remove the manifest.toml file in the examples folder before running the notebook?

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.