search

ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
237 stars 24 forks source link

Fix broken tests #302

Closed bvdmitri closed 2 months ago

bvdmitri commented 2 months ago

This PR fixes some tests. I'm not completely sure why things changed, but it seems mostly because of the order in which message updates were done. Most tests showed small changes and in Gamma mixture model the FE is even better, but in the univariate gaussian mixture case, the free energy became worse. I tweaked the test because it was giving somewhat inconsistent results

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.19%. Comparing base (246b196) to head (411b5e7). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #302 +/- ## ======================================= Coverage 83.19% 83.19% ======================================= Files 18 18 Lines 1297 1297 ======================================= Hits 1079 1079 Misses 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

albertpod commented 2 months ago

LGTM, but examples fail

bvdmitri commented 2 months ago

The examples fail due to https://github.com/ReactiveBayes/TinyHugeNumbers.jl/issues/3, I'll work on it today

bvdmitri commented 2 months ago

Tests are fixed now, could you approve if you agree with the changes?