search

ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
https://rxinfer.ml/
MIT License
278 stars 23 forks source link

missalignment in plot of example: examples/basic_examples/Coin Toss Model.ipynb? #324

Closed juliusaka closed 3 months ago

juliusaka commented 4 months ago

Hi, I'm trying to understand Bayesian Inference, which is why I look through your examples. In the above mentioned example, examples/basic_examples/Coin Toss Model.ipynb, The model is called for inference with model = coin_model(a=4.0, b = 8.0), while in the plot at the end the prior is plotted with, plot!(rθ, (x) -> pdf(Beta(2.0, 7.0), x), fillalpha=0.3, fillrange = 0, label="P(θ)", c=1,). Can you please clarifiy if that is a missalignment, or help me in my understanding? Best, Julius

bvdmitri commented 4 months ago

Good catch, @juliusaka! You're absolutely right—the plot should use the model's parameters. We likely overlooked this during the example refactoring. Could you prepare a pull request with the fix? It's a great way to contribute to RxInfer!

mhidalgoaraya commented 4 months ago

I am out of the office but for sure I take care of it next week.

On Wed, 17 Jul 2024 at 11:04, Bagaev Dmitry @.***> wrote:

Good catch, @juliusaka https://github.com/juliusaka! You're absolutely right—the plot should use the model's parameters. We likely overlooked this during the example refactoring. Could you prepare a pull request with the fix? It's a great way to contribute to RxInfer!

— Reply to this email directly, view it on GitHub https://github.com/ReactiveBayes/RxInfer.jl/issues/324#issuecomment-2232807251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJSD34JFWGGYZ5GQNTRNBCLZMYXSNAVCNFSM6AAAAABLABQCHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSHAYDOMRVGE . You are receiving this because you were assigned.Message ID: @.***>