Closed albertpod closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Base: 80.12% // Head: 80.21% // Increases project coverage by +0.08%
:tada:
Coverage data is based on head (
dc5549e
) compared to base (a7cb2ce
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @albertpod for the new demo! There a couple of missing parts in this PR though. Currently your demo is not compatible with our examples pipeline: read documentation here.
Important points:
.meta.jl
file in the examples/
folder (also read comments in this file).Load dataset
and before the inference, it looks like you do the inference procedure in the Load dataset
section.@meta
instead of where { meta = ... }
showprogress = false
, the CI pipeline runs once and it looks like RxInfer is very slow, but its actually Julia's compilation timemake examples specific=ARMA
(specific=<Part of the title>
)The demo is working now. Thanks @albertpod, I want to tag a new release with 3 new demos, so I'll merge your PR now. If you think it needs further improvements please open a new PR. Thanks!
This PR adds a new demo on the Bayesian treatment of the ARMA model.