ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
259 stars 24 forks source link

ARMA demo #33

Closed albertpod closed 1 year ago

albertpod commented 1 year ago

This PR adds a new demo on the Bayesian treatment of the ARMA model.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.12% // Head: 80.21% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (dc5549e) compared to base (a7cb2ce). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== + Coverage 80.12% 80.21% +0.08% ========================================== Files 10 10 Lines 1107 1122 +15 ========================================== + Hits 887 900 +13 - Misses 220 222 +2 ``` | [Impacted Files](https://codecov.io/gh/biaslab/RxInfer.jl/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab) | Coverage Δ | | |---|---|---| | [src/graphppl.jl](https://codecov.io/gh/biaslab/RxInfer.jl/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab#diff-c3JjL2dyYXBocHBsLmps) | `87.00% <0.00%> (-0.50%)` | :arrow_down: | | [src/model.jl](https://codecov.io/gh/biaslab/RxInfer.jl/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab#diff-c3JjL21vZGVsLmps) | `86.47% <0.00%> (+0.75%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bvdmitri commented 1 year ago

Thanks @albertpod for the new demo! There a couple of missing parts in this PR though. Currently your demo is not compatible with our examples pipeline: read documentation here.

Important points:

bvdmitri commented 1 year ago

The demo is working now. Thanks @albertpod, I want to tag a new release with 3 new demos, so I'll merge your PR now. If you think it needs further improvements please open a new PR. Thanks!