ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
270 stars 23 forks source link

The nonlinear sensor fusion demo is broken #52

Closed bvdmitri closed 1 year ago

bvdmitri commented 1 year ago

The inference is broken in the example https://biaslab.github.io/RxInfer.jl/stable/examples/Nonlinear%20Sensor%20Fusion/

Check the plots with the inference results

Nimrais commented 1 year ago

@bvdmitri @albertpod

I am near to the fix. There is a super stupid one (to remove the optional check on the proper messages and the plots will be correct). But It's possible to fix it by tuning with CVI hyperparameters: also, I think it's valuable because we will have a clear example to the user that hyperparameters are important.

I expect to end it to 24.02.2023.

albertpod commented 1 year ago

@Nimrais please update the end date of this fix ;)

Nimrais commented 1 year ago

@albertpod I will end the fix at 06.03.2023.

albertpod commented 1 year ago

@Nimrais, I think it's rather impossible :) I've updated the end date, hope that's what you've meant.

Nimrais commented 1 year ago

@albertpod Sure, I meant March not February.