ReactiveBayes / RxInfer.jl

Julia package for automated Bayesian inference on a factor graph with reactive message passing
MIT License
254 stars 24 forks source link

fix: allow unproper messages in sensor fusion demo (first model) #86

Closed Nimrais closed 1 year ago

Nimrais commented 1 year ago

This PR fixes https://github.com/biaslab/RxInfer.jl/issues/52.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

albertpod commented on 2023-03-13T10:36:50Z ----------------------------------------------------------------

Line #8.        initmessages = (z = MvNormalMeanPrecision(zeros(2), 0.1 * diageye(2)),),

Why have you increased the precision in this example?


codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (5d0279e) 79.88% compared to head (f53781c) 79.88%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #86 +/- ## ======================================= Coverage 79.88% 79.88% ======================================= Files 11 11 Lines 1173 1173 ======================================= Hits 937 937 Misses 236 236 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biaslab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.