search

ReactiveCircus / android-emulator-runner

A GitHub Action for installing, configuring and running hardware-accelerated Android Emulators on macOS virtual machines.
Apache License 2.0
977 stars 193 forks source link

Add port parameter #383

Closed KamilKurde closed 4 months ago

KamilKurde commented 8 months ago

The problem

Currently, this action uses ADB commands without specifying device/emulator to use. This is fine for GitHub-hosted machines, as they are isolated from each other, but becomes a problem when using this action on self-hosted machine, as ADB commands will fail if there are multiple devices present, and it wasn't specified which one to use.

The fix

Adding emulator-port input, that allows a job to specify port to start emulator on. This way, one machine could have up to 16 emulators running at the same time (due to constraints in port range) without interfering with each other.

pankajkakkar commented 4 months ago

May I please add a vote for getting this PR merged? It doesn't sound like there are any blockers from the conversation above. I'm facing this issue as well, and every time I want to run a workflow on my repo I have to shut down any running emulators on my Mac.

There's also an open issue https://github.com/ReactiveCircus/android-emulator-runner/issues/293 on this topic.