ReactiveCocoa / ReactiveObjCBridge

Bridge between ReactiveObjC and ReactiveSwift
MIT License
63 stars 39 forks source link

fix exhaustive switch error in Xcode 9 #30

Closed hirad closed 7 years ago

hirad commented 7 years ago

Accounting for the new case in DispatchTimeInterval has been done in other ReactiveCocoa projects, but not this one.

mdiep commented 7 years ago

This is great! Thanks for opening a PR!

erwald commented 7 years ago

@mdiep Any way we can make a 1.0.3 release with just this fix? // Greetings from Xcode9b3 user. ;)

mdiep commented 7 years ago

We can definitely do that.

Would you mind opening a PR that gets everything set for a 1.1 release?

Once that's done and merged, then I can actually tag a release.

erwald commented 7 years ago

Sure! Branching it off of d527356 (the 1.0.2 commit)? Because we have other stuff on master which I suppose we don't want in.

mdiep commented 7 years ago

I think the other things on master are okay. Everything looks additive to me.

ikesyo commented 7 years ago

Update ReactiveSwift in Cartfile to specify ~> 1.1.5

The requirement in podspec should also be updated.

erwald commented 7 years ago

All right, I'll do it tonight. 👍