search

ReactiveCocoa / ReactiveObjCBridge

Bridge between ReactiveObjC and ReactiveSwift
MIT License
63 stars 39 forks source link

ReactiveObjCBridge errors on Swift master; possibly add this repo to Swift source compat suite? #49

Open benasher44 opened 6 years ago

benasher44 commented 6 years ago

Hi there! A recent regression makes this repo fails to type check on Swift master: https://bugs.swift.org/browse/SR-7341. It's still not fixed, and it's unclear whether or not this will be fixed. I suppose this is more of a PSA, but there are some possible next steps:

  1. Change the name of one of the isEnabled properties in question (not ideal).
  2. If you feel so inclined, contribute a patch to Swift that fixes the regression or help find someone who can do so.
  3. Figure out how to add this repo to https://github.com/apple/swift-source-compat-suite

This last step would help both prevent issues and the future and raise more awareness about the current issue. Given the dependencies in this repo, I think a separate repo would need to be opened by the maintainers (part of the "Have maintainers who will commit to resolve issues in a timely manner" requirement of that suite) that includes all of the dependencies in a single project.

Thanks for your time and consideration!

benasher44 commented 6 years ago

Looks like the root issue was fixed #51

mdiep commented 6 years ago

ReactiveSwift is already part of the source compatibility suite, fwiw.

benasher44 commented 6 years ago

Oh awesome! Would be great to get this repo added as well then!