Updated Quick, Nimble and ReactiveObjc for swift 4.2 support

ReactiveCocoa / ReactiveObjCBridge

Bridge between ReactiveObjC and ReactiveSwift

MIT License

63 stars 39 forks source link

Updated Quick, Nimble and ReactiveObjc for swift 4.2 support #55

Closed jakovi89 closed 5 years ago

jakovi89 commented 5 years ago

Currently pointing at an intermediate branch for ReactiveObjc, supporting Swift 4.2
Updates Quick and Nimble to Swift 4.2 versions
Updates CI to Xcode 10.2

mdiep commented 5 years ago

CI failed. It looks like this PR still needs some work.

jakovi89 commented 5 years ago

hmm.. Watch OS still fails, I'm looking into it

jakovi89 commented 5 years ago

I'm somewhat in doubt why the Watch target will try to compile the UITextView+Rac on the CI, since these isn't part of the "compile sources". @mdiep do you have an idea why?

jakovi89 commented 5 years ago

It seems that the WatchOS target isn't choosing the correct target from ReactiveObjc

mdiep commented 5 years ago

This is probably the old Xcode bug where it doesn't pick the correct platform for some reason. In the past, we've gotten around this by turning off implicit dependencies in the scheme and making the dependencies explicit.

jakovi89 commented 5 years ago

Thanks for the hint @mdiep 👍

mdiep commented 5 years ago

Thanks! I made a new release with this: https://github.com/ReactiveCocoa/ReactiveObjCBridge/releases/tag/5.0.0