ReactiveCouchbase / ReactiveCouchbase-play

Play 2 plugin for ReactiveCouchbase
Apache License 2.0
40 stars 23 forks source link

Play Framework 2.4.2 #47

Open Tuan-PA opened 8 years ago

Tuan-PA commented 8 years ago

Please support Play Framework version 2.4.2

Currently, I get an error when intergrate reactivecouchbase into play framework 2.4.2

1) Could not find a suitable constructor in org.reactivecouchbase.play.plugins.CouchbasePlugin. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private. [info] at org.reactivecouchbase.play.plugins.CouchbasePlugin.class(CouchbasePlugin.scala:12) [info] while locating org.reactivecouchbase.play.plugins.CouchbasePlugin .....

chenbekor commented 8 years ago

big +1 on that

@mathieuancelin here is a summary of my thoughts on this subject:

-- play 2.4.x is a major change mainly due to the addition of dependency injection -- in order to sustain reactivecouchbase as the only known scala OS for non blocking interaction with Couchbase, the play framework community needs your help in porting to 2.4.x -- backward compatibility is important. you can decide that the 0.4 ver is the last version for play 2.3.x but maybe you have a better idea on how to support both 2.3.x and 2.4.x -- at minimum we need reactivecouchbase to just work / compile with 2.4.x -- a more preferable approach would be to add support for the new DI infra so that we could easily inject the couch client in runtime allowing us to detach couchbase during unit tests in favour of mocking -- of course we need a play example app that demonstrate reactivecouchbase working with 2.4.x

thank you!!

sammyluo commented 8 years ago

+1 !

roccobruno commented 8 years ago

+1!!