Namings of newly added inventory items

[Duke-M-commits]

After adding the new inventory items to my profile I realized the popup doesn't show tags: As opposed to the item description in the inventory (marked in red): Thus, I propose to implement the items rarity into the items display name (marked in green).

Also: Since the items include medals, stickers as also fun items (like the toilet) I would propose to name them Collectibles instead of Medals. In this case it would be named Common Collectible.

Here's an example of how that looks for an cs:go item.

I personally see the ingame promotions more fitting to the name medals as they are given to the commander for playing for a longer time and getting more skilled. I say that just for clarification, I don't think there should be renamings in that part of the game.

[BenLubar]

The reason they say "Medal" (or some variant thereof) is that that's the slot you can equip them in. I'm open to changing any of the display_type values as long as it's still easy to tell where the item can be equipped.

We can also rename the medal equip slot to collectable or trinket or something and keep the internal name as medal.

[Duke-M-commits]

The reason they say "Medal" (or some variant thereof) is that that's the slot you can equip them in. I'm open to changing any of the display_type values as long as it's still easy to tell where the item can be equipped.

We can also rename the medal equip slot to collectable or trinket or something and keep the internal name as medal.

I'm not sure who "they" are. Also I can't seem to find a place ingame which really gives the slots a name. I believe with slots you mean the 2 small places in the lobby which show the selected medal from the collections-menu and the current promotion/level of the player. Please clarify.

[BenLubar]

I'll hope this clarifies:

The reason the display_type of most items with item_slot set to medal is some variant of "Medal", "Community Medal", etc. is that the equip slot is medal ( rd_equipped_medal, see rd_inventory_shared.cpp for where they're defined)

Currently medal is the only equip slot that affects what you see in the game in any meaningful way. Weapon equips change the name of a weapon when you try to pick it up to include your Steam name, but nobody has a weapon item because the rest isn't ready for testing yet.

The slot name is shown on the collections screen tab. We can definitely rename the slot to "Collectibles" or "Trinkets" or something else like that (it'll need to keep its internal name of medal to not break stuff due to our system of having two active versions of the game, just like how Mender is called asw_shaman internally).

[Duke-M-commits]

Thanks for the clarification. I hope I find the time until next monday to implement the following renamings in the UI:

• [Community] Medal -> <rarity> Collectible
• Medals -> Collectibles in the collections screen (I find 'trinkets' fitting better into a fantasy setting than sci-fi)

Regarding weapon names, giving weapons player names could also be realized as name-tags like this:

[BenLubar]

What I mean by "player name" is that the message would show "[E] Pick up Ben Lubar's Rifle" rather than just "[E] Pick up Rifle"

[Duke-M-commits]

Reference #752