ReactiveDrop / reactivedrop_public_src

Alien Swarm: Reactive Drop game source code and issue tracker.
https://reactivedrop.com
105 stars 35 forks source link

Remove "out of meds" phrase from radial menu's central option? #701

Closed WhenTanksFly closed 6 months ago

WhenTanksFly commented 6 months ago

Other marines' pools for the middle button are gameplay-meaningless chitchat, yet both medics have a chance to lie about their ammo reserves. Pretty sure those lines shouldn't be there. ... Does the same issue apply to idle chatter?

BenLubar commented 6 months ago

Looks like there are 25 possible voice lines for each marine for that option. Currently working on annotating them in the source code. Right now they're just numbers with no explanations.

BenLubar commented 6 months ago

@WhenTanksFly alright, there's already quite a bit of overlap. what do we replace the two bad medic lines with?

https://github.com/ReactiveDrop/reactivedrop_public_src/blob/15fef4b9a2e5e4df623d50a13a089b68238d82a8/src/game/server/swarm/asw_marine_speech.cpp#L1001 https://github.com/ReactiveDrop/reactivedrop_public_src/blob/15fef4b9a2e5e4df623d50a13a089b68238d82a8/src/game/server/swarm/asw_marine_speech.cpp#L1046

BenLubar commented 6 months ago

Personally I'd go with incoherent screaming but I'm also open to actually good suggestions.