ReactiveRaven / jqBootstrapValidation

A JQuery validation framework for bootstrap forms.
http://reactiveraven.github.io/jqBootstrapValidation
MIT License
1.35k stars 334 forks source link

jqBootstrapValidation.js is not working with Bootstrap v3.0.2 #135

Open pushpitf9 opened 10 years ago

pushpitf9 commented 10 years ago

Hello Dear,

I have been using your jqBootstrapValidation.js for few months. It was fine.

Bootstrap has been upgraded from 2.3 to 3.0.

Your jqBootstrapValidation.js is nor working with Bootstrap3.0.

Please check once

peterb-2795 commented 10 years ago

+1 on this. It is a great validation utility.

Main issues with bootstrap 3 are: a) reorganising/naming form classes b) changes in the CSS

I have been through the JS and found that a few global changes gets it 90% working, viz: change ".control-group" to ".form-group" (3 instances) change ".controls" to ".form-control" (1 instance) change validation state class identifiers "error", "warning", "success" to "has-error", "has-warning", "has-success"

I also did a global replace of controlGroup -> formGroup to reflect the syntax used in bootstrap 3 more correctly.

Of course, you will need to re-write your html to be bs3 compliant.

I really like the way this validation library works -> kudos to the author. It would be great to have an officially updated version.

drmuey commented 10 years ago

+1 for me too, great library, great approach, just need BS3 support. The changes above don't seem to do the trick for me though.

If I figure out why that makes me get an “Uncaught RangeError: Maximum call stack size exceeded” from jQuery when I focus on a data-validation-match-match field I’ll see about doing a pull request maybe.

peterb-2795 commented 10 years ago

It has been working like a charm for me since I modified it over 3 months ago. However, I am sure I am not using 100% coverage of the lib so perhaps there might be a surprise lurking within for me. I'll deal with that when I meet it!! I am using:

drmuey commented 10 years ago

Thanks, for the info, I’d love to get this sorted if I have time

FWIW, mine is: • jQuery 1.11.0 • bootstrap 3.1.1