search

ReactiveX / IxJS

The Interactive Extensions for JavaScript
https://reactivex.io/IxJS/
MIT License
1.32k stars 73 forks source link

add abort signal to 'from' function and fix bug for 'merge' function #357

Closed eunohshure closed 8 months ago

eunohshure commented 9 months ago

Description:

  1. from operator doesn't take signal for async iterable source.
  2. merge function can cause unhandled rejected promise condition

Related issue (if exists):

  1. https://github.com/ReactiveX/IxJS/issues/352
  2. https://github.com/ReactiveX/IxJS/issues/353
trxcllnt commented 8 months ago

I have the merge fix in #354, but the change breaks the unit tests. It's not immediately obvious to me what the issue is.

trxcllnt commented 8 months ago

I updated #354 with a different fix, and now the code in #353 runs without exiting due to an unhandled exception error.