ReactiveX / IxJS

The Interactive Extensions for JavaScript
https://reactivex.io/IxJS/
MIT License
1.32k stars 73 forks source link

fix(toMap): fix return type of keySelector #365

Closed berndfuhrmann closed 4 months ago

berndfuhrmann commented 4 months ago

change return type of keySelector from TElement to TKey, since keySelector returns keys, not elements

Closes: #364

Description: change return type of keySelector to TKey. This might be a breaking change for existing code in rare cases. But then the programmer would very likely have worked around the bug this PR fixes. Feedback welcome.

Related issue (if exists):

364

trxcllnt commented 4 months ago

Thanks for the PR!